gateway flag changes breaking release e2e#14418
Merged
james-prysm merged 5 commits intodevelopfrom Sep 5, 2024
Merged
Conversation
rkapka
reviewed
Sep 5, 2024
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
rkapka
approved these changes
Sep 5, 2024
saolyn
approved these changes
Sep 5, 2024
james-prysm
added a commit
that referenced
this pull request
Sep 6, 2024
* e2e release test breaks due to changes in flag naming * changing approach to fix * adding some small alias test * fixing test, changelog, and flag name * Update config_test.go Co-authored-by: Radosław Kapka <rkapka@wp.pl> --------- Co-authored-by: Radosław Kapka <rkapka@wp.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
#14089 changed the flags for gateway, the release e2e uses the previous version to run e2e so that we know settings did not change. in this case the default name of the flag changed and a temporary use of the alias in the e2e test will be needed in the mean time until a future release where the updated name can then be used.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements